totalo commented on a change in pull request #10840:
URL: https://github.com/apache/shardingsphere/pull/10840#discussion_r655890685



##########
File path: 
shardingsphere-infra/shardingsphere-infra-context/src/main/java/org/apache/shardingsphere/infra/context/metadata/impl/StandardMetaDataContexts.java
##########
@@ -67,6 +67,16 @@ public StandardMetaDataContexts(final Map<String, 
ShardingSphereMetaData> metaDa
         this.props = props;
         stateContext = new StateContext();
     }
+
+    public StandardMetaDataContexts(final Map<String, ShardingSphereMetaData> 
metaDataMap, final ShardingSphereRuleMetaData globalRuleMetaData,

Review comment:
       In principle, yes, but I'll get rid of the old constructors as soon as I 
make sure the PR works. I'll add todo to the old constructor later, what do you 
think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to