tian-pengfei opened a new pull request, #4187:
URL: https://github.com/apache/shenyu/pull/4187

   <!-- Describe your PR here; eg. Fixes #issueNo -->
   
   <!--
   Thank you for proposing a pull request. This template will guide you through 
the essential steps necessary for a pull request.
   -->
   Make sure that:
   
   - [x] You have read the [contribution 
guidelines](https://shenyu.apache.org/community/contributor-guide).
   - [ ] You submit test cases (unit or integration tests) that back your 
changes.
   - [x] Your local test passed `./mvnw clean install 
-Dmaven.javadoc.skip=true`.
   
   when I tested signing function of the sign plugin,I found It is not the same 
as the function description of the document.
   should be :
   ```tex
   
path/springcloud/class/annotation/gettimestamp1668393864220version1.0.0EA8919756AFF40A3896AFEA161E23B29
   ```
   actual:
   
![0530a3b79d788f385781a6480e457fd](https://user-images.githubusercontent.com/42602026/201589295-658178eb-4091-42d3-b84f-476eea7cc3c1.png)
   
   
   But I found this commit(#4089) from git history ,its not good for no request 
body in signing
   
   
   **in addition**
   I think the commit #4089 is not good enough for solving the bug #4080
   
   First We can define a simple json format to calculate the sign
   
   ```json
   {
       
"header":"path/api/service/abc?id=123timestamp1571711067186version1.0.0506EEB535CF740D7A755CB4B9F4A1536",
       "body":"id123nameorder"
   }
   ```
   or
   ```json
   {
       "header":{
           "path":"path/api/service/abc?id=123",
           "timestamp":"1571711067186",
           "version":"1.0.0",
           "appKey":"506EEB535CF740D7A755CB4B9F4A1536"
       },
       "body":{
           "id":"path/api/service/abc?id=123",
           "name":"order"
       }
   }
   ```
   the body is optional
   ```java
   sign = DigestUtils.md5DigestAsHex(json.getBytes()).toUpperCase()
   ```
   
   **in addition**
   I found there are too many parameters in request header, I think we could 
redesign with reference to JWT format
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to