[GitHub] [shenyu] tian-pengfei commented on a diff in pull request #4187: [type:bugfix]Fixed signing function of the sign plugin When there is no request body

Mon, 14 Nov 2022 07:19:01 -0800 


tian-pengfei commented on code in PR #4187:
URL: https://github.com/apache/shenyu/pull/4187#discussion_r1021671720


##########
shenyu-plugin/shenyu-plugin-sign/src/main/java/org/apache/shenyu/plugin/sign/service/DefaultSignService.java:
##########
@@ -126,6 +126,6 @@ private Pair<Boolean, String> sign(final ShenyuContext 
shenyuContext, final Serv
     }
 
     private String buildExtSignKey(final String signKey, final ShenyuContext 
shenyuContext) {
-        return String.join("", Constants.TIMESTAMP, 
shenyuContext.getTimestamp(), Constants.PATH, shenyuContext.getPath(), 
Constants.VERSION, "1.0.0", signKey);
+        return String.join("", Constants.PATH, shenyuContext.getPath(), 
Constants.TIMESTAMP, shenyuContext.getTimestamp(), Constants.VERSION, "1.0.0", 
signKey);

Review Comment:
   
![image](https://user-images.githubusercontent.com/42602026/201695269-ea672d8f-c2c4-4aeb-911e-8461f46631db.png)
   
   after https://github.com/apache/shenyu/pull/4089 ,Actually its funticon 
doesnt meet the documentation description,I change that ,it can be compatible  
when there is no request body. but  its still incompatible ,when there have 
request body



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to