yu199195 commented on code in PR #4187:
URL: https://github.com/apache/shenyu/pull/4187#discussion_r1021655210
##########
shenyu-plugin/shenyu-plugin-sign/src/main/java/org/apache/shenyu/plugin/sign/service/DefaultSignService.java:
##########
@@ -126,6 +126,6 @@ private Pair<Boolean, String> sign(final ShenyuContext
shenyuContext, final Serv
}
private String buildExtSignKey(final String signKey, final ShenyuContext
shenyuContext) {
- return String.join("", Constants.TIMESTAMP,
shenyuContext.getTimestamp(), Constants.PATH, shenyuContext.getPath(),
Constants.VERSION, "1.0.0", signKey);
+ return String.join("", Constants.PATH, shenyuContext.getPath(),
Constants.TIMESTAMP, shenyuContext.getTimestamp(), Constants.VERSION, "1.0.0",
signKey);
Review Comment:
Why change this order? According to the documentation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
