moremind commented on code in PR #5598:
URL: https://github.com/apache/shenyu/pull/5598#discussion_r1689174626


##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/listener/http/HttpLongPollingDataChangedListener.java:
##########
@@ -139,46 +144,47 @@ public void doLongPolling(final HttpServletRequest 
request, final HttpServletRes
         // AsyncContext.settimeout() does not timeout properly, so you have to 
control it yourself
         asyncContext.setTimeout(0L);
         // block client's thread.
-        scheduler.execute(new LongPollingClient(asyncContext, clientIp, 
HttpConstants.SERVER_MAX_HOLD_TIMEOUT));
+        scheduler.execute(new LongPollingClient(asyncContext, clientIp, 
HttpConstants.SERVER_MAX_HOLD_TIMEOUT, namespaceId));
     }
 
     @Override
     protected void afterAppAuthChanged(final List<AppAuthData> changed, final 
DataEventTypeEnum eventType) {
-        scheduler.execute(new DataChangeTask(ConfigGroupEnum.APP_AUTH));
+        scheduler.execute(new DataChangeTask(ConfigGroupEnum.APP_AUTH, ""));

Review Comment:
   why empty string?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to