moremind commented on code in PR #5598:
URL: https://github.com/apache/shenyu/pull/5598#discussion_r1802279325
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/listener/http/HttpLongPollingDataChangedListener.java:
##########
@@ -187,7 +193,8 @@ private List<ConfigGroupEnum> compareChangedGroup(final
HttpServletRequest reque
}
String clientMd5 = params[0];
long clientModifyTime = NumberUtils.toLong(params[1]);
- ConfigDataCache serverCache = CACHE.get(group.name());
+
+ ConfigDataCache serverCache = CACHE.get(namespaceId + "_" +
group.name());
Review Comment:
you can new a method to change this, may `buildCacheKey`
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/listener/http/HttpLongPollingDataChangedListener.java:
##########
@@ -94,7 +98,7 @@ public class HttpLongPollingDataChangedListener extends
AbstractDataChangedListe
* @param httpSyncProperties the HttpSyncProperties
*/
public HttpLongPollingDataChangedListener(final HttpSyncProperties
httpSyncProperties) {
- this.clients = new ArrayBlockingQueue<>(1024);
+ this.clientsMap = new CompactHashMap<>();
Review Comment:
why use this? why not hashmap?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
