moremind commented on code in PR #5598:
URL: https://github.com/apache/shenyu/pull/5598#discussion_r1759750399
##########
shenyu-admin/src/test/java/org/apache/shenyu/admin/listener/AbstractDataChangedListenerTest.java:
##########
@@ -70,6 +73,10 @@ public final class AbstractDataChangedListenerTest {
private DiscoveryUpstreamService discoveryUpstreamService;
+ private final String namespaceId = "649330b6-c2d7-4edc-be8e-8a54df9eb385";
Review Comment:
not use magic value,, use common value
##########
shenyu-admin/src/test/java/org/apache/shenyu/admin/controller/ConfigControllerTest.java:
##########
@@ -71,12 +71,12 @@ public void setUp() {
public void testFetchConfigs() throws Exception {
// Configure HttpLongPollingDataChangedListener.fetchConfig(...).
final ConfigData<?> configData = new ConfigData<>("md5-value1", 0L,
Collections.emptyList());
-
doReturn(configData).when(mockLongPollingListener).fetchConfig(ConfigGroupEnum.APP_AUTH);
+
doReturn(configData).when(mockLongPollingListener).fetchConfig(ConfigGroupEnum.APP_AUTH,
"649330b6-c2d7-4edc-be8e-8a54df9eb385");
Review Comment:
not use magic value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
