BobSong-dev commented on PR #7512: URL: https://github.com/apache/shenyu/pull/7512#issuecomment-6072515594
Thank you for the detailed review and for running the checks. I have pushed the following changes in `0eb57cd4c`: 1. Kept the conservative whole-entry fail-closed policy for this first version, including local tools, and made its scope explicit. An unavailable remote catalog now returns HTTP 503 / JSON-RPC `-32023` (`Remote catalog unavailable`). No automatic local-only or last-good-generation fallback is introduced. 2. Removed the unused two-argument starter assembly overload. 3. Removed `X-Spike-Subject` without replacing it with another identity header. Outbound authentication uses only fixed service credentials; Agent context remains inside the gateway. 4. Replaced the conversation-related comment with the technical rationale for stable `server.tool` naming. 5. Connected response diagnostics to a debug logger, limited to server, method, generated request ID, status and byte count. Credentials, identity and response bodies are not logged. 6. Documented `LocalTool`/`withLocal` as an extension point for native-result local providers, separate from the production provider registry. 7. Added plugin-config compatibility and migration notes to the README and release notes. 8. Cleaned up the reviewed fully qualified names and extra blank lines. I also fixed a reproduced control-update race in `cd873402c`: a superseded enable update can no longer initialize a remote client after the plugin is disabled or its remote configuration is removed. Local verification passed: 419 targeted tests on Windows/Admin and 354 on RISC-V/QEMU, with zero failures, errors or skipped tests. Checkstyle/RAT, the real Admin → WebSocket → gateway chain, and six OpenCode modes using the configured real model also passed. These are local results, not confirmation that all GitHub checks have passed. Please let me know if you would prefer a narrower failure scope for the initial version. Thank you again for your guidance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
