BobSong-dev commented on PR #7512:
URL: https://github.com/apache/shenyu/pull/7512#issuecomment-6093100487
Thank you very much for the detailed review. I have addressed the remaining
issues and the non-blocking suggestions in `7bee45438`, and synchronized with
master through the ordinary merge `302186212`.
- Catalog reservation, build and publication failures now consistently use
the
sanitized catalog-unavailable exception. Cleanup quarantine cannot publish
a replacement directory. The whole-entry fail-closed policy is unchanged.
- Failure diagnostics are scoped to the latest control-event revision; older
fenced updates cannot restore stale failures or overwrite a newer failure.
The empty-resource path and the build non-null invariant are now explicit.
- Raw and typed calls share the lease/argument-snapshot helper. Typed
immutable
diagnostics remove the string-key casts from tests, while the existing map
export remains compatible. I also extracted the error message/codes,
renamed
the fence predicate to `stillCurrent` and cleaned up inline qualified
names.
- Added JSON/SSE checks for diagnostic keys, types, status, generated ids,
byte
counts and absence of private request data. Added address regressions for
`0.0.0.0` and `255.255.255.255`, which the existing policy already rejects.
- Documented the actual catalog boundary: one catalog per gateway application
context, fed by its configured namespace's data-sync channel. This does not
introduce an in-process multi-namespace router.
- The Admin merge resolution retains master's relation-existence/namespace
ownership assertions and both Agent configuration validations. All three
upstream relation tests remain, and the Agent tests use an explicit
namespace.
Merged-head local verification: 484 targeted tests in 32 suites, with zero
failures, errors or skips; Checkstyle/RAT passed across 47 modules. The real
local
Admin/H2/WebSocket gateway checks passed again: entry 40, coexistence 12,
aggregation 22 and configuration sync 6. Owned catalog/session resources
drained
before shutdown; runtime class origins and artifact credential checks passed.
Thank you again for your guidance. I would appreciate your review of the
update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
