harshkha3417 commented on PR #7749: URL: https://github.com/apache/shenyu/pull/7749#issuecomment-6244828087
Thanks for the detailed review @Aias00! I've addressed all the feedback and rebased the branch onto the latest `master`: 1. **Coordination with #7765**: `doSyncDB()` now keeps the per-instance `try/catch` granularity over a defensive snapshot copy (`copyInstanceInfoVO(vo)`), ensuring a single row failure does not abort subsequent records while preserving snapshot isolation. 2. **Bounded shutdown lock**: Replaced `synchronized` with `ReentrantLock` and added `syncDB(timeout, unit)`. `close()` now uses a 5-second `tryLock` bounded timeout to prevent blocking `@PreDestroy` indefinitely if a sync is stalled on JDBC. 3. **Prevent executor leak on re-election**: Added `closeExecutors()` at the beginning of `setup()` to shut down existing executors before re-initializing. 4. **Tests & verification**: Added unit tests covering per-instance error handling, executor shutdown on re-election, and bounded shutdown lock acquisition. All tests pass with 0 checkstyle violations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
