harshkha3417 commented on PR #7749:
URL: https://github.com/apache/shenyu/pull/7749#issuecomment-6258238266
### CI Failure Root Cause & Resolution
The failure in the CI build and prbuild checks was caused by an upstream
conflict between two recently merged commits on `master`:
1. **Root Cause:**
- **#7785 (`7086afaff`):** Introduced canonical JSON normalization via
`InstanceInfoUtils.normalize()`, which normalizes non-JSON text payloads to
`"{}"`.
- **#7721 (`315bcbc3d`):** Added tests in `InstanceCheckServiceTest`
using plain text (`"version=1.0"`). On the initial beat, `InstanceCheckService`
normalized `"version=1.0"` to `"{}"`, leading to test failures when asserting
against `"version=1.0"`.
- Additionally, heartbeat refreshes for already-cached instances in
`InstanceCheckService.handleBeatInfo()` were setting raw strings without
calling `InstanceInfoUtils.normalize()`.
2. **Fix:**
- Applied `InstanceInfoUtils.normalize(...)` to heartbeat updates on
existing identities in `InstanceCheckService.handleBeatInfo()`.
- Updated the test payloads in `InstanceCheckServiceTest`
(`testHandleBeatInfoRefreshesInstanceInfoOnExistingIdentity` and
`testHandleBeatInfoKeepsInstanceInfoWhenBeatCarriesBlank`) to use valid JSON
object strings (`"{\"version\":\"1.0\"}"` and `"{\"version\":\"2.0\"}"`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
