konlue commented on PR #7749: URL: https://github.com/apache/shenyu/pull/7749#issuecomment-6245269885
@harshkha3417 PTAL. Heads-up for after apache/shenyu#7742 (approved — adds `id` to `InstanceInfoVO` ) merges: the `copyInstanceInfoVO` snapshot introduced here enumerates all VO fields and will leave the new `id` null. Harmless today ( `createOrUpdate` never reads the VO id), but to keep the complete-copy invariant, please add `copy.setId(vo.getId())` once #7742 lands — happy to follow up with the one-liner myself if you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
