EvanLjp commented on a change in pull request #10:
URL:
https://github.com/apache/skywalking-satellite/pull/10#discussion_r546352636
##########
File path: Makefile
##########
@@ -67,7 +67,9 @@ test: clean lint
.PHONY: license
license: clean tools
- $(GO_LICENSER) -d -exclude=protocol/gen-codes -licensor='Apache
Software Foundation (ASF)' .
+ $(GO_LICENSER) -d -exclude=plugins/queue/mmap \
Review comment:
The exclude feature of the licensor is only working in a dir. When
refactoring the file to a single dir, a serious problem would be occurring,
that is circle reference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
