wu-sheng commented on a change in pull request #10:
URL:
https://github.com/apache/skywalking-satellite/pull/10#discussion_r546359397
##########
File path: Makefile
##########
@@ -67,7 +67,9 @@ test: clean lint
.PHONY: license
license: clean tools
- $(GO_LICENSER) -d -exclude=protocol/gen-codes -licensor='Apache
Software Foundation (ASF)' .
+ $(GO_LICENSER) -d -exclude=plugins/queue/mmap \
Review comment:
This is the typle case of decoupling the codes. I think there are enough
design patterns to fix this.
Anyway, if tool supports file level exclusion, should be better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
