EvanLjp commented on a change in pull request #10:
URL:
https://github.com/apache/skywalking-satellite/pull/10#discussion_r546356841
##########
File path: Makefile
##########
@@ -67,7 +67,9 @@ test: clean lint
.PHONY: license
license: clean tools
- $(GO_LICENSER) -d -exclude=protocol/gen-codes -licensor='Apache
Software Foundation (ASF)' .
+ $(GO_LICENSER) -d -exclude=plugins/queue/mmap \
Review comment:
for example, there are 2 influenced files, which are queue.go and
queue_opreation.go. If refactoring the queue_opreation.go to
bigqueue/queue_opreation.go, circle reference would be occurringing. The `
queue.go` in mmap package imports bigqueue package, some operations in bigqueue
package are also dependent on the map package.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
