kezhenxu94 commented on pull request #20: URL: https://github.com/apache/skywalking-nodejs/pull/20#issuecomment-752952837
> `listener` would be different for different instances of `on-finished` module and so not sure what would happen but they might wind up overwriting each other's queues of listeners. Yes that is indeed a problem that I didn't realize before, thanks for sharing. > And I see how the time difference problem is caused in the reverted HttpPlugin, just need to bind `stopIfNotStopped()` to the actual end of the response processing without using `on-finished` (and verify change in order of span stop is ok). Yep the tests result shows this problem exactly, and that's what I said without `on-finished` the efforts is not ignorable. P.S. I'm also finding some hooks of import / require that may avoid the problem of the different instances, something like https://stackoverflow.com/questions/24602136/import-hooks-in-node-js , need some tryings though ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
