tom-pytel edited a comment on pull request #20: URL: https://github.com/apache/skywalking-nodejs/pull/20#issuecomment-752961509
> > As for http I am sure there is a way to do it, I may just duplicate part of `on-finished` mechanism locally (doesn't look too difficult). > > Hopefully this can be extracted as an individual reusable module / class. Also note not to copy the codes from on-finished because of licensing issues. Actually not even extract anything, I think its just adding a listener on request socket error or close and removing the `stopIfNotStopped()` in response listener. > This is the last sort if it really needs. Just to search and see we have a fallback solution. What problem are you actually trying to solve? Do you want to hook `require()` so that plugins are only installed when they are loaded? Or do you want to `require()` from the top level, which is what `PluginInstaller.require()` does? Or is it something else? BTW: I don't know why the tests errored here, my test is fine with your latest push. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
