tom-pytel commented on pull request #21:
URL: https://github.com/apache/skywalking-nodejs/pull/21#issuecomment-753640477
The problem was that on return from the request hook before there was no way
to tell if then next exit span was going to be another axios request or the
http request for this axios request or even if it would be a completely
unrelated http request (no easy way to tell if it belongs to this axios
request), so either async() needed to be applied or no. The solution was to do
a deeper axios hook as close to the http request as it could be and luckily
this was possible so that the http request even wound up being in the same
async context as the hook, so no need for async() here.
I discovered another problem though which is not even axios but more general
since it exists with normal http request as well. I am not sure if it was
working before or if I just did not notice, but if I do my test with the
multiple async requests like:
```js
await Promise.all(new Array(100).fill().map(() => downloadPageA('localhost',
8100, '/')));
```
Only the first 14-21 or so have a correlated entry span in express server.
This is the case whether the request is axios or just simple http. Not sure if
this is a hard-coded limit somewhere or some resource is being exhausted, could
you take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
