[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #21: fix: AxiosPlugin async() / resync()

[GitBox]

tom-pytel commented on pull request #21:
URL: https://github.com/apache/skywalking-nodejs/pull/21#issuecomment-753942531


   > Well this doesn't look good even on web UI
   > 
   > Actual:
   > <img alt="image" width="1345" 
src="https://user-images.githubusercontent.com/15965696/103495460-ce0c8800-4e75-11eb-9137-b46757d48677.png";>
   > 
   > Expected:
   > <img alt="image" width="760" 
src="https://user-images.githubusercontent.com/15965696/103495512-f7c5af00-4e75-11eb-8d99-437cdb98a910.png";>
   > 
   > Ignore the component name in latter picture, just for reference of the 
hierarchy
   
   Ok, well this version actually solves all the problems I was having in my 
stuff with Axios so this has to be a tweak somewhere, will check. But the 
double spans (http + axios) for outgoing requests are gone no?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org