tom-pytel commented on pull request #21: URL: https://github.com/apache/skywalking-nodejs/pull/21#issuecomment-753952608
> > But the double spans (http + axios) for outgoing requests are gone no? > > I'd say it is worse, the duplicated spans are gone but the segments are duplicated now. Actually I see what the problem is and it is not Axios (at least not directly). First of all, since Axios is async the test case client.ts should be creating an async request handler function and awaiting it (like the server.ts does correctly). The second and more important part is that the http plugin does not handle async request handlers AT ALL, so need to add that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
