tom-pytel commented on pull request #21: URL: https://github.com/apache/skywalking-nodejs/pull/21#issuecomment-754116405
So have a look, if you update the expected data for the tests I think this is better than ever. Wound up fixing something we didn't even know was a problem - lack of http async server handlers. But take these post-release problems as a demonstration of how important regression tests will be for this agent. Async programming can be tricky and it is very easy to break something, even with minor changes. I suggest you add a lot of tests to this agent, especially multiple concurrent requests like my test example. If you do not, I guarantee you the next person who adds a plugin and is not familiar with the inner workings of this will break everything. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
