tom-pytel commented on pull request #21:
URL: https://github.com/apache/skywalking-nodejs/pull/21#issuecomment-754113551
Well, it turns out that `stopIfNotStopped()` at the end of http request
response event handler we removed before to fix timings was there for another
important reason - order of span stop. The new stop mechanism `res.on('end',
stopIfNotStopped)` seems actually to be the best way of doing it and gives even
better timing consistency than without it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
