[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6403: Enhance gRPC log appender to allow layout pattern

[GitBox]

kezhenxu94 commented on a change in pull request #6403:
URL: https://github.com/apache/skywalking/pull/6403#discussion_r579662723



##########
File path: test/e2e/pom.xml
##########
@@ -44,6 +44,8 @@
     </modules>
 
     <properties>
+        <sw.version>8.5.0-SNAPSHOT</sw.version>

Review comment:
       > ${env.SKYWALKING_VERSION}
   
   With this, the local IDE won't work unless you manually replace this with 
the existing version, you cannot even set environment variable in the IDE (see 
my screenshot below).
   
   <img width="1791" alt="image" 
src="https://user-images.githubusercontent.com/15965696/108598565-44832c00-73c9-11eb-9af5-bc67f4158621.png";>
   
   If the developers have to replace `${env.SKYWALKING_VERSION}` with an actual 
version, it's highly possible it would be checked into the codebase.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org