[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6403: Enhance gRPC log appender to allow layout pattern

Sat, 20 Feb 2021 06:44:31 -0800 


kezhenxu94 commented on a change in pull request #6403:
URL: https://github.com/apache/skywalking/pull/6403#discussion_r579665734



##########
File path: test/e2e/pom.xml
##########
@@ -44,6 +44,8 @@
     </modules>
 
     <properties>
+        <sw.version>8.5.0-SNAPSHOT</sw.version>

Review comment:
       > Doesn't this work?
   > 
   > 
![image](https://user-images.githubusercontent.com/5441976/108599495-69c56980-73cc-11eb-8bfc-bc8ac4c1cf53.png)
   
   This is running configuration (take effect in Java application or JUnit test 
case), not in maven's lifecycle, and, the pom.xml takes effect at compile phase.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to