wu-sheng commented on a change in pull request #6403:
URL: https://github.com/apache/skywalking/pull/6403#discussion_r579670098
##########
File path: test/e2e/pom.xml
##########
@@ -44,6 +44,8 @@
</modules>
<properties>
+ <sw.version>8.5.0-SNAPSHOT</sw.version>
Review comment:
> but we need to pay attention to PRs that when developers modify
${env.SKYWALKING_VERSION} to something like 8.5.0-SNAPSHOT
How about we add a step in the CI to make sure the version is
`${env.SKYWALKING_VERSION}`(or EMPTY?), before we set it by ourselves.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
