wu-sheng commented on a change in pull request #6937:
URL: https://github.com/apache/skywalking/pull/6937#discussion_r633927122
##########
File path:
apm-sniffer/bootstrap-plugins/jdk-http-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdk/http/HttpClientNewInstanceInterceptor.java
##########
@@ -18,23 +18,23 @@
package org.apache.skywalking.apm.plugin.jdk.http;
+import java.lang.reflect.Method;
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
-import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.StaticMethodsAroundInterceptor;
-
-import java.lang.reflect.Method;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.v2.MethodInvocationContext;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.v2.StaticMethodsAroundInterceptorV2;
-public class HttpClientNewInstanceInterceptor implements
StaticMethodsAroundInterceptor {
+public class HttpClientNewInstanceInterceptor implements
StaticMethodsAroundInterceptorV2 {
@Override
public void beforeMethod(Class clazz, Method method, Object[]
allArguments, Class<?>[] parameterTypes,
- MethodInterceptResult result) {
+ MethodInterceptResult result,
MethodInvocationContext context) {
Review comment:
I am feeling `MethodInterceptResult` and `MethodInvocationContext`
should be merged, as result to override the execution result is a case of MIC
usages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
