wu-sheng commented on a change in pull request #6937:
URL: https://github.com/apache/skywalking/pull/6937#discussion_r635269938
##########
File path:
apm-sniffer/optional-plugins/mybatis-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/mybatis/define/MyBatisShellMethodInstrumentation.java
##########
@@ -21,31 +21,32 @@
import net.bytebuddy.description.method.MethodDescription;
import net.bytebuddy.matcher.ElementMatcher;
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.ConstructorInterceptPoint;
-import
org.apache.skywalking.apm.agent.core.plugin.interceptor.InstanceMethodsInterceptPoint;
-import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.ClassInstanceMethodsEnhancePluginDefine;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.v2.ClassEnhancePluginDefineV2;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.v2.InstanceMethodsInterceptV2Point;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.v2.StaticMethodsInterceptV2Point;
import org.apache.skywalking.apm.agent.core.plugin.match.ClassMatch;
import org.apache.skywalking.apm.plugin.mybatis.MyBatisMethodMatch;
import static
org.apache.skywalking.apm.agent.core.plugin.match.NameMatch.byName;
-public class MyBatisShellMethodInstrumentation extends
ClassInstanceMethodsEnhancePluginDefine {
+public class MyBatisShellMethodInstrumentation extends
ClassEnhancePluginDefineV2 {
Review comment:
Why extending `ClassEnhancePluginDefineV2`? Where is
`ClassInstanceEnhancePluginDefineV2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
