wu-sheng commented on a change in pull request #6937:
URL: https://github.com/apache/skywalking/pull/6937#discussion_r634869739
##########
File path:
apm-sniffer/apm-sdk-plugin/avro-plugin/src/main/java/org/apache/skywalking/apm/plugin/avro/AbstractRequestInterceptor.java
##########
@@ -24,13 +24,15 @@
import org.apache.avro.ipc.Requestor;
import org.apache.avro.ipc.Transceiver;
import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.tag.StringTag;
import org.apache.skywalking.apm.agent.core.logging.api.ILog;
import org.apache.skywalking.apm.agent.core.logging.api.LogManager;
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceConstructorInterceptor;
-import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.v2.InstanceMethodsAroundInterceptorV2;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.v2.MethodInvocationContext;
-public abstract class AbstractRequestInterceptor implements
InstanceConstructorInterceptor, InstanceMethodsAroundInterceptor {
+public abstract class AbstractRequestInterceptor implements
InstanceConstructorInterceptor, InstanceMethodsAroundInterceptorV2 {
Review comment:
Yes, it is. But it is not suitable to change. The better case is about
this plugin,
https://github.com/apache/skywalking/pull/6913#pullrequestreview-654964408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
