kezhenxu94 commented on a change in pull request #125: URL: https://github.com/apache/skywalking-python/pull/125#discussion_r665185963
########## File path: docs/Plugins.md ########## @@ -18,6 +18,7 @@ Library | Versions | Plugin Name | [sanic](https://sanic.readthedocs.io/en/latest/) | >= 20.3.0 <= 20.9.1 | `sw_sanic` | | [aiohttp](https://sanic.readthedocs.io/en/latest/) | >= 3.7.3 | `sw_aiohttp` | | [pyramid](https://trypyramid.com) | >= 1.9 | `sw_pyramid` | -| [psycopg2](https://www.psycopg.org/) | 2.8.6 | `sw_psycopg2` | +| [psycopg2](https://www.psycopg.org/) | >= 2.8.6 | `sw_psycopg2` | +| [celery](https://docs.celeryproject.org/) | >= 4.2.1 | `sw_celery` | Review comment: Let's be clear that this plugin only works in `http` protocol ########## File path: skywalking/config.py ########## @@ -59,13 +59,14 @@ kafka_bootstrap_servers = os.getenv('SW_KAFKA_REPORTER_BOOTSTRAP_SERVERS') or "localhost:9092" # type: str kafka_topic_management = os.getenv('SW_KAFKA_REPORTER_TOPIC_MANAGEMENT') or "skywalking-managements" # type: str kafka_topic_segment = os.getenv('SW_KAFKA_REPORTER_TOPIC_SEGMENT') or "skywalking-segments" # type: str +celery_parameters_length = int(os.getenv('SW_CELERY_PARAMETERS_LENGTH') or '512') def init( service: str = None, instance: str = None, collector: str = None, - protocol_type: str = 'grpc', + protocol_type: str = None, Review comment: I'd rather leave `grpc` as default protocol and switch to `http` in the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
