kezhenxu94 commented on a change in pull request #125:
URL: https://github.com/apache/skywalking-python/pull/125#discussion_r667484219
##########
File path: setup.py
##########
@@ -33,12 +33,13 @@
author="Apache",
author_email="[email protected]",
license="Apache 2.0",
- packages=find_packages(exclude=("tests",)),
+ packages=find_packages(exclude=("tests", "tests.*")),
include_package_data=True,
install_requires=[
"grpcio",
"grpcio-tools",
"packaging",
+ "requests",
Review comment:
Hi @tom-pytel I missed this in this PR, but this makes `requests` a
mandatory dependency of skywalking-python, please also take a look at
https://github.com/apache/skywalking/issues/7282 that `requests` depends on a
LGPL licensed dependency that we cannot ship with in ASF project. As we have
this in `extras_require/http`, can we just remove this? When users want to use
`http` protocol, they can use something like `pip install
skywalking-python[http]`.
FYI @wu-sheng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
