kezhenxu94 commented on a change in pull request #125:
URL: https://github.com/apache/skywalking-python/pull/125#discussion_r667485055
##########
File path: setup.py
##########
@@ -33,12 +33,13 @@
author="Apache",
author_email="[email protected]",
license="Apache 2.0",
- packages=find_packages(exclude=("tests",)),
+ packages=find_packages(exclude=("tests", "tests.*")),
include_package_data=True,
install_requires=[
"grpcio",
"grpcio-tools",
"packaging",
+ "requests",
Review comment:
> Why a plugin requires an agent-level dependency?
We support grpc and http protocols, for http protocol, we use `requests` to
send http requests, as we use grpc as default protocol and http is optional
(can be installed by `pip install skywalking-python[http]`), I think @tom-pytel
missed that and wanted to test http protocol so he add the dependency here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
