hanahmily commented on a change in pull request #30:
URL: https://github.com/apache/skywalking-banyandb/pull/30#discussion_r685746426
##########
File path: banyand/liaison/grpc/testdata/server_cert.pem
##########
@@ -0,0 +1,32 @@
+-----BEGIN CERTIFICATE-----
Review comment:
To copy source codes needs another process more than lib dependency.
It's much easy to generate TLS files by referring to
https://bbengfort.github.io/2017/03/secure-grpc/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
