Fine0830 commented on a change in pull request #30:
URL: https://github.com/apache/skywalking-banyandb/pull/30#discussion_r685795244



##########
File path: banyand/liaison/grpc/grpc.go
##########
@@ -49,26 +49,35 @@ import (
 )
 
 var (
-       ErrSeriesEvents    = errors.New("no seriesEvent")
-       ErrShardEvents     = errors.New("no shardEvent")
-       ErrInvalidSeriesID = errors.New("invalid seriesID")
+       ErrSeriesEvents       = errors.New("no seriesEvent")
+       ErrShardEvents        = errors.New("no shardEvent")
+       ErrInvalidSeriesID    = errors.New("invalid seriesID")
+       ErrServerCert         = errors.New("invalid server cert file")
+       ErrServerKey          = errors.New("invalid server key file")
+       ErrServerHostOverride = errors.New("invalid serverHostOverride")
+       ErrNoAddr             = errors.New("no address")
 )
 
 type Server struct {
-       addr       string
-       log        *logger.Logger
-       ser        *grpclib.Server
-       pipeline   queue.Queue
-       repo       discovery.ServiceRepo
-       shardInfo  *shardInfo
-       seriesInfo *seriesInfo
+       addr               string
+       maxRecvMsgSize     int
+       TLSVal             bool
+       ServerHostOverride string
+       CertFile           string

Review comment:
       I export them for  the `grpc_test`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to