wu-sheng commented on a change in pull request #3017: fix deleteIndex repeat
append namespace
URL: https://github.com/apache/skywalking/pull/3017#discussion_r300832124
##########
File path:
oap-server/server-library/library-client/src/main/java/org/apache/skywalking/oap/server/library/client/elasticsearch/ElasticSearchClient.java
##########
@@ -146,7 +146,13 @@ public JsonObject getIndex(String indexName) throws
IOException {
}
public boolean deleteIndex(String indexName) throws IOException {
- indexName = formatIndexName(indexName);
+ return deleteIndex(indexName, true);
+ }
+
+ public boolean deleteIndex(String indexName, boolean formatIndexName)
throws IOException {
Review comment:
These two delete methods will make people very confused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
