wu-sheng commented on a change in pull request #3017: fix deleteIndex repeat
append namespace
URL: https://github.com/apache/skywalking/pull/3017#discussion_r300850634
##########
File path:
oap-server/server-library/library-client/src/main/java/org/apache/skywalking/oap/server/library/client/elasticsearch/ElasticSearchClient.java
##########
@@ -292,7 +300,14 @@ public int delete(String indexName, String
timeBucketColumnName, long endTimeBuc
public String formatIndexName(String indexName) {
if (StringUtils.isNotEmpty(namespace)) {
- return namespace + "_" + indexName;
+ return namespacePrefix + indexName;
+ }
+ return indexName;
+ }
+
+ public String undoFormatIndexName(String indexName) {
Review comment:
This should be private.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
