wu-sheng commented on a change in pull request #3017: fix deleteIndex repeat
append namespace
URL: https://github.com/apache/skywalking/pull/3017#discussion_r300871648
##########
File path:
oap-server/server-library/library-client/src/test/java/org/apache/skywalking/oap/server/library/client/elasticsearch/ITElasticSearchClient.java
##########
@@ -51,7 +52,10 @@
@Before
public void before() throws IOException {
final String esAddress = System.getProperty("elastic.search.address");
- client = new ElasticSearchClient(esAddress, "", "test", "test");
+ final String esNamespace =
System.getProperty("elastic.search.namespace", "");
+ final String esUser = System.getProperty("elastic.search.user",
"test");
+ final String esPassword =
System.getProperty("elastic.search.password", "test");
Review comment:
If not, then, namespace feature hasn't been tested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
