wu-sheng commented on a change in pull request #8193:
URL: https://github.com/apache/skywalking/pull/8193#discussion_r757825293
##########
File path:
oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/AccessLogServiceGRPCHandler.java
##########
@@ -105,7 +110,7 @@ public AccessLogServiceGRPCHandler(ModuleManager manager,
public void onNext(StreamAccessLogsMessage message) {
HistogramMetrics.Timer timer = histogram.createTimer();
try {
- if (isFirst) {
+ if (isFirst || (alwaysAnalyzeIdentity &&
message.getIdentifier() != null)) {
Review comment:
Reply to
https://github.com/apache/skywalking/pull/8193#issuecomment-980809798
@kezhenxu94 I don't think this will affect the parsing here. The parsing is
already done, this if protobuf, not flatbuffer.
So, the only one more cost is reading `message.getIdentifier()`, which is a
Java bean getting only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
