mrproliu commented on a change in pull request #8193:
URL: https://github.com/apache/skywalking/pull/8193#discussion_r757828427
##########
File path:
oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/AccessLogServiceGRPCHandler.java
##########
@@ -105,7 +110,7 @@ public AccessLogServiceGRPCHandler(ModuleManager manager,
public void onNext(StreamAccessLogsMessage message) {
HistogramMetrics.Timer timer = histogram.createTimer();
try {
- if (isFirst) {
+ if (isFirst || (alwaysAnalyzeIdentity &&
message.getIdentifier() != null)) {
Review comment:
If you want I could do the experiment, we also using the new protocol
and the `OAP` side is using current and this one. Then I post the so11y metrics.
```java```
if (isFirst || (alwaysAnalyzeIdentity && message.getIdentifier() != null)) {
identifier = message.getIdentifier();
isFirst = false;
role = Role.NONE;
}
for (ALSHTTPAnalysis analysis : envoyHTTPAnalysisList) {
role = analysis.identify(identifier, role);
}
```java```
I think only this one could find the identity analysis whether there is a
performance problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
