wu-sheng commented on a change in pull request #8193:
URL: https://github.com/apache/skywalking/pull/8193#discussion_r757828259
##########
File path:
oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/AccessLogServiceGRPCHandler.java
##########
@@ -105,7 +110,7 @@ public AccessLogServiceGRPCHandler(ModuleManager manager,
public void onNext(StreamAccessLogsMessage message) {
HistogramMetrics.Timer timer = histogram.createTimer();
try {
- if (isFirst) {
+ if (isFirst || (alwaysAnalyzeIdentity &&
message.getIdentifier() != null)) {
Review comment:
I am not sure why this possiblily could be high. You are comparing this
logic between one stream and 2k+ streaming. Then you have a conclusion, this
one streaming has higher possible to parse identify.
More parsing per stream, yes, but no different when condidering this whole
2k streamings(2k envoy instances)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
