kezhenxu94 commented on a change in pull request #8193:
URL: https://github.com/apache/skywalking/pull/8193#discussion_r757828486
##########
File path:
oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/AccessLogServiceGRPCHandler.java
##########
@@ -105,7 +110,7 @@ public AccessLogServiceGRPCHandler(ModuleManager manager,
public void onNext(StreamAccessLogsMessage message) {
HistogramMetrics.Timer timer = histogram.createTimer();
try {
- if (isFirst) {
+ if (isFirst || (alwaysAnalyzeIdentity &&
message.getIdentifier() != null)) {
Review comment:
> If you mean flatbuffer parsing, then this is really having no
different than before.
I never mean flatbuffer parsing. I meant this part
```java
for (ALSHTTPAnalysis analysis : envoyHTTPAnalysisList) {
role = analysis.identify(identifier, role);
}
```
> I think your gap is that, you are not considering we merged the stream,
currently, one stream is representing the previous multiple streaming, then
logically, all those identifiers are pasred too, just through different
streamings.
I’m rather aware of that you merged the streams, and because you merge the
streams from different Envoy nodes the OAP needs to identify the node in every
message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
