peng-yongsheng commented on issue #3017: fix deleteIndex repeat append namespace URL: https://github.com/apache/skywalking/pull/3017#issuecomment-509683948 > > > @peng-yongsheng If you just want an easy way, please consider putting two good method names. Because time series indexes exist, we can't set these methods as `#deleteByIndexName` and `#deleteByModelName`. > > > In time series case, the model `A` has indexes including `A-20190913`,`A-20190914`, etc., but we can't call `#deleteByModelName(A)`(I know we don't use in this way). But still, show the API is hard named. > > > > > > Agree with my two hands. > > Now, I only think `ElasticSearchTimeSeriesIndex ` redundant Yes, If you use it, it's not the only place that needs it. It is a strategy that how to manage the namespace. Not just for the delete method. So, I do not suggest you use this way. I had thought it at the time of I program the time series implementation. At that time, I had an ideal same as you. But, If we must keep the overall style of the code. I found there are too many codes that need to modify.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
