peng-yongsheng commented on issue #3017: fix deleteIndex repeat append namespace URL: https://github.com/apache/skywalking/pull/3017#issuecomment-509696816 > > If you interest in how to manage the namespace. I think we can talk about providing a new class named ModelName with at least two attributes. Namespace and model name. And a method to build the final name and a method to split it. > > Yes, but wouldn't it be better to know the namespace with less code No problem, you can new an issue to discuss it. > > Fixed this PR, think it in the another PR. > > Do I need to make any modification to this PR Yes, just provide those two methods, '#deleteByIndexName' and '#deleteByModelName'. Rollback other changed files.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
