peng-yongsheng commented on issue #3017: fix deleteIndex repeat append namespace URL: https://github.com/apache/skywalking/pull/3017#issuecomment-509686689 > > > @peng-yongsheng If you just want an easy way, please consider putting two good method names. Because time series indexes exist, we can't set these methods as `#deleteByIndexName` and `#deleteByModelName`. > > > In time series case, the model `A` has indexes including `A-20190913`,`A-20190914`, etc., but we can't call `#deleteByModelName(A)`(I know we don't use in this way). But still, show the API is hard named. > > > > > > Agree with my two hands. > > Now, I only think `ElasticSearchTimeSeriesIndex ` redundant @Arugal If you interest in how to manage the namespace. I think we can talk about providing a new class named ModelName with at least two attributes. Namespace and model name. And a method to build the final name, and a method to split it. Fixed this PR, think it in the another PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
