hanahmily commented on pull request #14: URL: https://github.com/apache/skywalking-showcase/pull/14#issuecomment-1001314982
> I remember there is swctl install to install OAP and UI, it's better we can install or generate agent manifest there too, the current usage in this pr looks kindof complex. For example, user provides their original yaml of the application, and pass them into our command, then our command populates the necessary part like annotations, etc., swctl inject java -f deployments/java-app.yaml | kubectl apply -f - The recommended path to onboard java agent injection is to install all SW backends through the SWCK operator. The operator provided several CRDs to manage OAP, UI, and other critical components. This model should be our canonical way. We could provide a manual-style injection to swctl to help users don't want to inject init container by webhooks automatically. But from experiences of istio, vault, and other projects who have similar injection workflows, the manual way is not widely used, because this style brings a steep learning curve to users since the operator reduced it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
