kezhenxu94 commented on a change in pull request #14:
URL: https://github.com/apache/skywalking-showcase/pull/14#discussion_r775419329
##########
File path: deploy/platform/kubernetes/feature-agent/resources.yaml
##########
@@ -44,14 +44,23 @@ spec:
template:
metadata:
labels:
+ # @feature: java-agent-injector; enable the java agent injector
+ swck-java-agent-injected: "true"
app: gateway
annotations:
sidecar.istio.io/inject: "${AGENTLESS}"
+ # @feature: java-agent-injector; set the java agent configuration
+ strategy.skywalking.apache.org/inject.Container: "gateway"
+ strategy.skywalking.apache.org/agent.Overlay: "true"
+ agent.skywalking.apache.org/agent.service_name: "agent::gateway"
spec:
containers:
- name: gateway
image: ${HUB}/gateway-service:${TAG}
Review comment:
> Is there a way we use `agentless` image here?(For Java) Because we
have injector already.
It's already agentless, check this `TAG=${TAG}-agentless`,
https://github.com/apache/skywalking-showcase/blob/3ee8f9923e29c542996735464949fd002a31fa70/deploy/platform/kubernetes/features.mk#L57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
