kezhenxu94 commented on a change in pull request #14:
URL: https://github.com/apache/skywalking-showcase/pull/14#discussion_r775414957
##########
File path: deploy/platform/kubernetes/feature-agent/resources.yaml
##########
@@ -44,14 +44,23 @@ spec:
template:
metadata:
labels:
+ # @feature: java-agent-injector; enable the java agent injector
+ swck-java-agent-injected: "true"
app: gateway
annotations:
sidecar.istio.io/inject: "${AGENTLESS}"
+ # @feature: java-agent-injector; set the java agent configuration
+ strategy.skywalking.apache.org/inject.Container: "gateway"
+ strategy.skywalking.apache.org/agent.Overlay: "true"
+ agent.skywalking.apache.org/agent.service_name: "agent::gateway"
spec:
containers:
- name: gateway
image: ${HUB}/gateway-service:${TAG}
Review comment:
> @kezhenxu94 Is this image already agent-based? If so, it could confuse
users.
`${TAG}` is substitutable, and it's substituted according to the feature
deployed, when deploying agent it's `xxxxx` when it's agentless it's
`xxxxx-agentless`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
