kezhenxu94 commented on a change in pull request #14:
URL: https://github.com/apache/skywalking-showcase/pull/14#discussion_r775429367
##########
File path: deploy/platform/kubernetes/feature-agent/resources.yaml
##########
@@ -88,14 +97,23 @@ spec:
template:
metadata:
labels:
+ # @feature: java-agent-injector; enable the java agent injector
+ swck-java-agent-injected: "true"
app: songs
annotations:
sidecar.istio.io/inject: "${AGENTLESS}"
+ # @feature: java-agent-injector; set the java agent configuration
+ strategy.skywalking.apache.org/inject.Container: "songs"
+ strategy.skywalking.apache.org/agent.Overlay: "true"
+ agent.skywalking.apache.org/agent.service_name: "agent::songs"
spec:
containers:
- name: songs
image: ${HUB}/songs-service:${TAG}
imagePullPolicy: Always
+ command: ["java"]
+ # @feature: java-agent-injector; we need to add $(AGENT_OPTS) to
enable the injected configuration
+ args: ${JAVA_AGENT}
Review comment:
> Yep, the injector needs to add the `AGENT_OPTS` to JVM argument like
`["$(AGENT_OPTS)","-jar","/app.jar"]`.
Sorry I didn't follow the related pull request in swck repo, but why don't
we use environment name `JAVA_TOOL_OPTIONS` so that JVM can automatically pick
this up and users don't need to modify their command?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
