dmsolr commented on a change in pull request #95:
URL:
https://github.com/apache/skywalking-nginx-lua/pull/95#discussion_r809745116
##########
File path: lib/skywalking/tracer.lua
##########
@@ -28,9 +28,7 @@ local nginxComponentId = 6000
local Tracer = {}
-function Tracer:start(upstream_name, correlation)
- local log = ngx.log
- local WARN = ngx.WARN
+function Tracer:start(upstream_name, correlation, is_propagation)
Review comment:
It will not set the propagation header to request when the
is_propagation is false.
If the peer is updated, the propagation header will become invalidated.
So I add this parameter for disabling propagation header when the one want
to update they peer.
Surely, I added a method for manual propagation in right moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
