dmsolr commented on a change in pull request #95:
URL:
https://github.com/apache/skywalking-nginx-lua/pull/95#discussion_r814450075
##########
File path: README.md
##########
@@ -131,7 +131,8 @@ The following APIs are for developers or using this lib out
of the Nginx case.
## Nginx APIs
- **startTimer**,
`require("skywalking.client"):startBackendTimer("http://127.0.0.1:8080";)`.
Start the backend timer. This timer register the metadata and report traces to
the backend.
- **destroyBackendTimer**,
`require("skywalking.client"):destroyBackendTimer()`. Stop the timer created by
`startBackendTimer`, and clean unreported data.
-- **start**, `require("skywalking.tracer"):start("upstream service",
correlation)`. Begin the tracing before the upstream begin. The custom data
(table type) can be injected as the second parameter, and then they will be
propagated to the downstream service.
+- **start**, `require("skywalking.tracer"):start("upstream service",
correlation)`. Begin the tracing before the upstream beginning. The custom data
(table type) can be injected as the second parameter, and then they will be
propagated to the downstream service. If `upstream service` could be determined
precisely later, keep it as `nil` and call `inject` method when peer(upstream
address) is resolved by load balancer and DNS resolver.
Review comment:
Look good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
