dmsolr commented on a change in pull request #95:
URL:
https://github.com/apache/skywalking-nginx-lua/pull/95#discussion_r809762668
##########
File path: lib/skywalking/tracer.lua
##########
@@ -28,9 +28,7 @@ local nginxComponentId = 6000
local Tracer = {}
-function Tracer:start(upstream_name, correlation)
- local log = ngx.log
- local WARN = ngx.WARN
+function Tracer:start(upstream_name, correlation, is_propagation)
Review comment:
We can get the actual peer and update the HTTP Header in apisix balance
phase(it is also ok for OpenResty).
Because we can set the HTTP Header of outgoing request in the balance phase,
it does not raise braking trace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
